Rajeshbabu Chintaguntla commented on PHOENIX-3242:

Uploaded the patch handling review comments.
bq. In this case "ALTER SYSTEM ADD JAR ..." seems about right.
I tried to change the COPY JAR query to ALTER SYSTEM ADD JAR but the query 
parsing is failing because calcite already have ALTER SYTEM statements to 
set/reset connection properties. So as of now changed it to UPLOAD JARS as 
[~jamestaylor] suggested.
bq. I'm not sure I like the idea of copy-pasting SqlParserTest from Calcite 
into Phoenix. It will break fairly often. Is it possible to create a sub-class 
of the test instead? 
In the latest patch extended SqlParserTest and added test for ddl statements. 

If I get +1 will rebase to latest code and commit it.
Ping [~maryannxue]

> Support CREATE OR REPLACE FUNCTION in Phoenix-Calcite Integration
> -----------------------------------------------------------------
>                 Key: PHOENIX-3242
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3242
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Rajeshbabu Chintaguntla
>            Assignee: Rajeshbabu Chintaguntla
>              Labels: calcite
>         Attachments: PHOENIX-3242-wip.patch, PHOENIX-3242_v1.patch, 
> PHOENIX-3242_v2.patch, PHOENIX-3242_v3.patch, PHOENIX-3242_v4.patch, 
> PHOENIX-3242_v5.patch

This message was sent by Atlassian JIRA

Reply via email to