[
https://issues.apache.org/jira/browse/PHOENIX-3242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15553369#comment-15553369
]
Maryann Xue commented on PHOENIX-3242:
--------------------------------------
Thank you very much, for your nice work, [~rajeshbabu]! I have probably created
some misunderstandings here by making test case changes in my own patch. The
goal is to implement missing feature and to fix bugs in Calcite-Phoenix and
it's ok that even after we have fixed certain things, some related test case
still do not work, for some other reasons. So basically we don't change test
cases just to let them pass, unless we know that they are issues with test
cases themselves, like using "date" as column names. I've noticed that there
are some changes in UserDefinedFunctionsIT that you made in order to run the
tests with Calcite-Phoenix driver instead of the old driver, such as changing
URLs, adding properties, etc. But there are also some other changes that are
supposed to cover Calcite-Phoenix bugs, like checking Exceptions. That said,
could you please do two things before checking in?
1. Revert the unnecessary changes in UserDefinedFunctionsIT.java. The Exception
issue has been addressed by https://issues.apache.org/jira/browse/PHOENIX-3345.
2. Split your patch into PHOENIX-3242 and PHOENIX-3351. Submit to PHOENIX-3351
and I'll review that separately. Then please go ahead and check-in for this
issue. It looks good to me.
Also, I think what [~julianhyde] mentioned as the named parameter and default
parameter interface this morning is in PhoenixScalarFunction already, which is
an implementation class for Calcite's ScalarFunction.
> Support CREATE OR REPLACE FUNCTION in Phoenix-Calcite Integration
> -----------------------------------------------------------------
>
> Key: PHOENIX-3242
> URL: https://issues.apache.org/jira/browse/PHOENIX-3242
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Rajeshbabu Chintaguntla
> Assignee: Rajeshbabu Chintaguntla
> Labels: calcite
> Attachments: PHOENIX-3242-WIP-2.patch, PHOENIX-3242-wip.patch,
> PHOENIX-3242_select-wip.patch, PHOENIX-3242_v1.patch, PHOENIX-3242_v2.patch,
> PHOENIX-3242_v3.patch, PHOENIX-3242_v4.patch, PHOENIX-3242_v5.patch,
> PHOENIX-3242_v6.patch, PHOENIX-3242_v7.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
