Maryann Xue commented on PHOENIX-3264:

Thank you, [~julianhyde], for the solution! Actually it's exactly what we do in 
which tests that a SQL string parsed by Calcite will be converted into the same 
Phoenix Expression as what it would if the string is parsed through old 
Phoenix. It is only that for this issue we won't have to go through the SQL 
string and parser again, coz we already have this SqlNode, we just need to wrap 
it in a SqlSelect. But the rest of the work should be pretty much the same as 
in ToExpressionTest.

> Allow TRUE and FALSE to be used as literal constants
> ----------------------------------------------------
>                 Key: PHOENIX-3264
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3264
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: James Taylor
>            Assignee: Eric Lomore
>         Attachments: Sql2RelImplementation.png, SqlLiteral.png, 
> SqlNodeToRexConverterImpl.png, SqlOptionNode.png, objectdependencies.png, 
> objectdependencies2.png, stacktrace.png
> Phoenix supports TRUE and FALSE as boolean literals, but perhaps Calcite 
> doesn't? Looks like this is leading to a fair number of failures.

This message was sent by Atlassian JIRA

Reply via email to