[
https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15533600#comment-15533600
]
ASF GitHub Bot commented on PHOENIX-3264:
-----------------------------------------
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/212#discussion_r81203125
--- Diff:
phoenix-core/src/main/java/org/apache/calcite/sql/SqlOptionNode.java ---
@@ -38,12 +41,10 @@ public SqlOptionNode(SqlParserPos pos, SqlIdentifier
key, SqlLiteral literal) {
familyName = key.names.get(0);
propertyName = key.names.get(1);
}
- final Object v = SqlLiteral.value(literal);
- if (v instanceof NlsString) {
- value = ((NlsString) v).toString();
- } else {
- value = v;
- }
+
+ PhoenixRelImplementor
+ implementor = new PhoenixRelImplementorImpl(new
RuntimeContextImpl());
--- End diff --
Looks like we need a "dummy" RuntimeContext for this kind of "dry run"
implementor. I'll do this part when I commit it.
> Allow TRUE and FALSE to be used as literal constants
> ----------------------------------------------------
>
> Key: PHOENIX-3264
> URL: https://issues.apache.org/jira/browse/PHOENIX-3264
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: James Taylor
> Assignee: Eric Lomore
> Attachments: Sql2RelImplementation.png, SqlLiteral.png,
> SqlNodeToRexConverterImpl.png, SqlOptionNode.png, objectdependencies.png,
> objectdependencies2.png, stacktrace.png
>
>
> Phoenix supports TRUE and FALSE as boolean literals, but perhaps Calcite
> doesn't? Looks like this is leading to a fair number of failures.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
