Github user maryannxue commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/212#discussion_r81203125
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/calcite/sql/SqlOptionNode.java ---
    @@ -38,12 +41,10 @@ public SqlOptionNode(SqlParserPos pos, SqlIdentifier 
key, SqlLiteral literal) {
                 familyName = key.names.get(0);
                 propertyName = key.names.get(1);
             }
    -        final Object v = SqlLiteral.value(literal);
    -        if (v instanceof NlsString) {
    -            value = ((NlsString) v).toString();
    -        } else {
    -            value = v;
    -        }
    +
    +        PhoenixRelImplementor
    +                implementor = new PhoenixRelImplementorImpl(new 
RuntimeContextImpl());
    --- End diff --
    
    Looks like we need a "dummy" RuntimeContext for this kind of "dry run" 
implementor. I'll do this part when I commit it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to