Github user lomoree commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/212#discussion_r81210767
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/calcite/CalciteUtils.java ---
    @@ -1036,4 +1048,40 @@ public Void visitCall(RexCall call) {
                 return null;
             }
         }
    +
    +    public static Object convertLiteral(SqlLiteral literal, 
PhoenixRelImplementor implementor) {
    +        try {
    +            final SchemaPlus rootSchema = 
Frameworks.createRootSchema(true);
    +            final FrameworkConfig config = Frameworks.newConfigBuilder()
    +                    .parserConfig(SqlParser.Config.DEFAULT)
    +                    .defaultSchema(rootSchema).build();
    +            Planner planner = Frameworks.getPlanner(config);
    --- End diff --
    
    I could also abstract this to the SqlOptionNode and pass it in to this 
method. I had that at one point but ended up opting for this since the code 
didn't seem like it belonged there. Let me know which you prefer.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to