Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/213#discussion_r81420342
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/execute/ClientScanPlan.java ---
@@ -106,12 +106,18 @@ public ExplainPlan getExplainPlan() throws
SQLException {
}
@Override
- public QueryPlan limit(Integer limit) {
- if (limit == this.limit || (limit != null &&
limit.equals(this.limit)))
+ public QueryPlan limit(Integer limit, Integer offset) {
+ if (limit == this.limit || (limit != null &&
limit.equals(this.limit))) {
--- End diff --
I can see there's a big confusion here. Basically, offset and limit should
be treated the same way. So here, it should be "if both the old limit and the
old offset are same as as the new ones specified, we return this; otherwise we
create a new object."
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
