Github user lomoree commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/213#discussion_r81421343
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/execute/ClientScanPlan.java ---
    @@ -106,12 +106,18 @@ public ExplainPlan getExplainPlan() throws 
SQLException {
         }
     
         @Override
    -    public QueryPlan limit(Integer limit) {
    -        if (limit == this.limit || (limit != null && 
limit.equals(this.limit)))
    +    public QueryPlan limit(Integer limit, Integer offset) {
    +        if (limit == this.limit || (limit != null && 
limit.equals(this.limit))) {
    --- End diff --
    
    This does definitely have ripple effects throughout, but I had done this on 
the basis that SQL only allows an offset if their is an imposed limit (since an 
offset doesn't make any logical sense without a limit).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to