[
https://issues.apache.org/jira/browse/PHOENIX-476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15610494#comment-15610494
]
Hudson commented on PHOENIX-476:
--------------------------------
FAILURE: Integrated in Jenkins build Phoenix-master #1451 (See
[https://builds.apache.org/job/Phoenix-master/1451/])
PHOENIX-476 Support declaration of DEFAULT in CREATE statement (Kevin
(jamestaylor: rev 5744c6f0eb7119e20122a24e93c0a0c6e98e9662)
* (add)
phoenix-core/src/main/java/org/apache/phoenix/schema/DelegateSQLException.java
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/compile/UpsertCompiler.java
* (edit)
phoenix-core/src/test/java/org/apache/phoenix/compile/WhereCompilerTest.java
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/compile/CreateTableCompiler.java
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
* (edit)
phoenix-core/src/test/java/org/apache/phoenix/compile/QueryCompilerTest.java
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/parse/CreateTableStatement.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/schema/types/PBinary.java
* (add)
phoenix-core/src/main/java/org/apache/phoenix/expression/function/DefaultValueExpression.java
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/parse/UseSchemaStatement.java
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/execute/TupleProjector.java
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/parse/CreateSchemaStatement.java
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/parse/ParseNodeFactory.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/schema/ColumnRef.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/parse/ColumnDef.java
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
* (edit) phoenix-core/src/main/antlr3/PhoenixSQL.g
* (add)
phoenix-core/src/it/java/org/apache/phoenix/end2end/DefaultColumnValueIT.java
* (edit)
phoenix-core/src/it/java/org/apache/phoenix/iterate/MockResultIterator.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/schema/PTableImpl.java
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/expression/ExpressionType.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/schema/PMetaDataImpl.java
> Support declaration of DEFAULT in CREATE statement
> --------------------------------------------------
>
> Key: PHOENIX-476
> URL: https://issues.apache.org/jira/browse/PHOENIX-476
> Project: Phoenix
> Issue Type: Task
> Affects Versions: 3.0-Release
> Reporter: James Taylor
> Assignee: Kevin Liew
> Labels: enhancement
> Fix For: 4.9.0
>
> Attachments: PHOENIX-476.10.patch, PHOENIX-476.11.patch,
> PHOENIX-476.12.patch, PHOENIX-476.2.patch, PHOENIX-476.3.patch,
> PHOENIX-476.4.patch, PHOENIX-476.5.patch, PHOENIX-476.6.patch,
> PHOENIX-476.7.patch, PHOENIX-476.8.patch, PHOENIX-476.9.patch,
> PHOENIX-476.patch
>
>
> Support the declaration of a default value in the CREATE TABLE/VIEW statement
> like this:
> CREATE TABLE Persons (
> Pid int NOT NULL PRIMARY KEY,
> LastName varchar(255) NOT NULL,
> FirstName varchar(255),
> Address varchar(255),
> City varchar(255) DEFAULT 'Sandnes'
> )
> To implement this, we'd need to:
> 1. add a new DEFAULT_VALUE key value column in SYSTEM.TABLE and pass through
> the value when the table is created (in MetaDataClient).
> 2. always set NULLABLE to ResultSetMetaData.columnNoNulls if a default value
> is present, since the column will never be null.
> 3. add a getDefaultValue() accessor in PColumn
> 4. for a row key column, during UPSERT use the default value if no value was
> specified for that column. This could be done in the PTableImpl.newKey method.
> 5. for a key value column with a default value, we can get away without
> incurring any storage cost. Although a little bit of extra effort than if we
> persisted the default value on an UPSERT for key value columns, this approach
> has the benefit of not incurring any storage cost for a default value.
> * serialize any default value into KeyValueColumnExpression
> * in the evaluate method of KeyValueColumnExpression, conditionally use
> the default value if the column value is not present. If doing partial
> evaluation, you should not yet return the default value, as we may not have
> encountered the the KeyValue for the column yet (since a filter evaluates
> each time it sees each KeyValue, and there may be more than one KeyValue
> referenced in the expression). Partial evaluation is determined by calling
> Tuple.isImmutable(), where false means it is NOT doing partial evaluation,
> while true means it is.
> * modify EvaluateOnCompletionVisitor by adding a visitor method for
> RowKeyColumnExpression and KeyValueColumnExpression to set
> evaluateOnCompletion to true if they have a default value specified. This
> will cause filter evaluation to execute one final time after all KeyValues
> for a row have been seen, since it's at this time we know we should use the
> default value.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
