[
https://issues.apache.org/jira/browse/PHOENIX-3461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15651588#comment-15651588
]
James Taylor commented on PHOENIX-3461:
---------------------------------------
Every test that runs as NeedsOwnCluster increases the time it takes for tests
to run. Also, StatsCollectorIT uses unique table names so there's no need to
have the BaseOwnClusterIT.cleanUpAfterTest() run after each test to drop all
tables.
You can either derive directly from BaseTest and add this method into
StatsCollectorIT:
{code}
@AfterClass
public static void doTeardown() throws Exception {
tearDownMiniCluster();
}
{code}
Or you can create a new base class that only has this method (an intermediate
class between BaseTest and BaseOwnClusterIT) and derive other tests from this
class that are now derived from BaseTest directly.
If you think there will be more tests that run with stats enabled and
namespaces enabled, you can create a new test category like I did for
ParallelStatsDisabledIT and ParallelStatsEnabledIT. This would enable a single
mini cluster to be spun up for all of these test classes and allow the test
methods to run in parallel.
> Statistics collection broken if name space mapping enabled for SYSTEM tables
> ----------------------------------------------------------------------------
>
> Key: PHOENIX-3461
> URL: https://issues.apache.org/jira/browse/PHOENIX-3461
> Project: Phoenix
> Issue Type: Bug
> Reporter: Samarth Jain
> Assignee: Samarth Jain
> Fix For: 4.9.0
>
> Attachments: PHOENIX-3461-v3.patch, PHOENIX-3461_master.patch,
> PHOENIX-3461_v2.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
