[
https://issues.apache.org/jira/browse/PHOENIX-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15655630#comment-15655630
]
ASF GitHub Bot commented on PHOENIX-3355:
-----------------------------------------
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/222#discussion_r87515184
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/parse/ParseNodeFactory.java ---
@@ -127,6 +129,7 @@ private static void addBuiltInFunction(Class<? extends
FunctionExpression> f) th
}
int nArgs = d.args().length;
BuiltInFunctionInfo value = new BuiltInFunctionInfo(f, d);
+ SINGLE_SIGNATURE_BUILT_IN_FUNCTION_MAP.put(value.getName(), value);
--- End diff --
We'll have to adjust the map initialization logic here according to the new
annotation. Avoid "ABSTRACT" for "SINGLE_SIGNATURE_BUILT_IN_FUNCTION_MAP" and
"DERIVED" for "BUILT_IN_FUNCTION_MAP".
> Register Phoenix built-in functions as Calcite functions
> --------------------------------------------------------
>
> Key: PHOENIX-3355
> URL: https://issues.apache.org/jira/browse/PHOENIX-3355
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: Eric Lomore
> Labels: calcite
> Attachments: PHOENIX-3355.function_constructor.patch,
> PHOENIX-3355.wip, PHOENIX-3355.wip2
>
>
> We should register all Phoenix built-in functions that don't exist in Calcite.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
