[ 
https://issues.apache.org/jira/browse/PHOENIX-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15648607#comment-15648607
 ] 

Maryann Xue commented on PHOENIX-3355:
--------------------------------------

[~lomoree], PHOENIX-3466 is in now. You can use 
PhoenixImplementor.getStatementContext() in CalciteUtils for function 
expression instantiation. Still I found that CurrentDateFunction does not have 
any arguments but do need a statement context to get the current timestamp. So 
the default value solution may simply be not enough. Please do follow 
[~jamestaylor]'s suggestion about checking for all {{nodeClass}} parameters in 
the {{@BuiltInFunction}} annotations. That way you can see all places where 
StatementContext is needed.

> Register Phoenix built-in functions as Calcite functions
> --------------------------------------------------------
>
>                 Key: PHOENIX-3355
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3355
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Eric Lomore
>              Labels: calcite
>         Attachments: PHOENIX-3355.function_constructor.patch, 
> PHOENIX-3355.wip, PHOENIX-3355.wip2
>
>
> We should register all Phoenix built-in functions that don't exist in Calcite.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to