[ https://issues.apache.org/jira/browse/PHOENIX-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15731335#comment-15731335 ]
ASF GitHub Bot commented on PHOENIX-2890: ----------------------------------------- Github user ankitsinghal commented on a diff in the pull request: https://github.com/apache/phoenix/pull/210#discussion_r91454865 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexMetadataIT.java --- @@ -216,6 +219,15 @@ public void testIndexCreateDrop() throws Exception { assertFalse(rs.next()); assertActiveIndex(conn, INDEX_DATA_SCHEMA, indexDataTable); + + ddl = "ALTER INDEX " + indexName + " ON " + INDEX_DATA_SCHEMA + QueryConstants.NAME_SEPARATOR + indexDataTable + " REBUILD ASYNC"; + conn.createStatement().execute(ddl); + // Verify the metadata for index is correct. + rs = conn.getMetaData().getTables(null, StringUtil.escapeLike(INDEX_DATA_SCHEMA), indexName , new String[] {PTableType.INDEX.toString()}); + assertTrue(rs.next()); + assertEquals(indexName , rs.getString(3)); + assertEquals(PIndexState.BUILDING.toString(), rs.getString("INDEX_STATE")); --- End diff -- This was taken care in the last commit. > Extend IndexTool to allow incremental index rebuilds > ---------------------------------------------------- > > Key: PHOENIX-2890 > URL: https://issues.apache.org/jira/browse/PHOENIX-2890 > Project: Phoenix > Issue Type: Improvement > Reporter: Ankit Singhal > Assignee: Ankit Singhal > Priority: Minor > Fix For: 4.10.0 > > Attachments: PHOENIX-2890.patch, PHOENIX-2890_wip.patch > > > Currently , IndexTool is used for initial index rebuild but I think we should > extend it to be used for recovering index from last disabled timestamp too. > In general terms if we run IndexTool on already existing/new index, then it > should follow the same semantics as followed by background Index rebuilding > thread. -- This message was sent by Atlassian JIRA (v6.3.4#6332)