[
https://issues.apache.org/jira/browse/PHOENIX-3517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15744347#comment-15744347
]
Nick Dimiduk commented on PHOENIX-3517:
---------------------------------------
Yeah looks like an improvement to me, +1. While you're in there, might as well
make --color configurable as well. That might be nice for folks who want to run
scripts.
Apply the same cleanup to sqlline.py as well?
+1
FYI I really like [docopt|http://docopt.org/] but that requires a module that
doesn't ship with the default install.
> Use argparse in sqlline-thin.py
> -------------------------------
>
> Key: PHOENIX-3517
> URL: https://issues.apache.org/jira/browse/PHOENIX-3517
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Josh Elser
> Assignee: Josh Elser
> Fix For: 4.10.0
>
> Attachments: PHOENIX-3517.patch
>
>
> sqlline-thin.py just does hand-rolled argument parsing. We can simplify the
> code, make better usage and validation choices, and support some extra
> options that we presently default to.
> Python's argparse does all of these for us.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
