[
https://issues.apache.org/jira/browse/PHOENIX-3517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15746658#comment-15746658
]
Josh Elser commented on PHOENIX-3517:
-------------------------------------
bq. While you're in there, might as well make --color configurable as well
Ooo, good idea!
bq. Apply the same cleanup to sqlline.py as well?
Yup, that's my plan.
bq. FYI I really like docopt but that requires a module that doesn't ship with
the default install.
I'm a real n00b when it comes to deploying code which depends on certain python
modules. Would somethign like virtualenv be a tool to use here? Or should we
just avoid opening the can of worms on non-default-modules entirely?
> Use argparse in sqlline-thin.py
> -------------------------------
>
> Key: PHOENIX-3517
> URL: https://issues.apache.org/jira/browse/PHOENIX-3517
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Josh Elser
> Assignee: Josh Elser
> Fix For: 4.10.0
>
> Attachments: PHOENIX-3517.patch
>
>
> sqlline-thin.py just does hand-rolled argument parsing. We can simplify the
> code, make better usage and validation choices, and support some extra
> options that we presently default to.
> Python's argparse does all of these for us.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
