[
https://issues.apache.org/jira/browse/PHOENIX-3563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15799893#comment-15799893
]
James Taylor commented on PHOENIX-3563:
---------------------------------------
Thanks for the patch, [~apurtell]! It looks good with one minor nit: How about
putting the {{txZKClientService.stopAndWait()}} call in a nested finally block?
We should probably do the same for the {{renewLeaseExecutor.shutdownNow()}}
call (if you feel like making this tweak too).
> Ensure we release ZooKeeper resources allocated by the Tephra client embedded
> in the Phoenix connection
> -------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-3563
> URL: https://issues.apache.org/jira/browse/PHOENIX-3563
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.9.0
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 4.9.1, 4.10.0, 5.0
>
> Attachments: PHOENIX-3563.patch, PHOENIX-3563.patch
>
>
> When transactions are enabled the Phoenix client will create some Tephra
> client objects, including TephraZKClientService, which embeds a ZooKeeper
> instance. Ensure that ZooKeeper instance is properly shut down via
> ZooKeeper#close.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
