[
https://issues.apache.org/jira/browse/PHOENIX-3563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15802367#comment-15802367
]
Hadoop QA commented on PHOENIX-3563:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12845843/PHOENIX-3563.patch
against master branch at commit a0e5efcec5a1a732b2dce9794251242c3d66eea6.
ATTACHMENT ID: 12845843
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
43 warning messages.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ this.connection =
HBaseFactoryProvider.getHConnectionFactory().createConnection(this.config);
+ // only initialize the tx service client if needed and if we
succeeded in getting a connection
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/718//testReport/
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/718//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/718//console
This message is automatically generated.
> Ensure we release ZooKeeper resources allocated by the Tephra client embedded
> in the Phoenix connection
> -------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-3563
> URL: https://issues.apache.org/jira/browse/PHOENIX-3563
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.9.0
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 4.9.1, 4.10.0, 5.0
>
> Attachments: PHOENIX-3563.patch, PHOENIX-3563.patch,
> PHOENIX-3563.patch
>
>
> When transactions are enabled the Phoenix client will create some Tephra
> client objects, including TephraZKClientService, which embeds a ZooKeeper
> instance. Ensure that ZooKeeper instance is properly shut down via
> ZooKeeper#close.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
