[
https://issues.apache.org/jira/browse/PHOENIX-3752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15941398#comment-15941398
]
Hadoop QA commented on PHOENIX-3752:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12860473/PHOENIX-3752.patch
against master branch at commit 2074d1f0a2dd2b03c2e3588ffd4d5f2395cc7505.
ATTACHMENT ID: 12860473
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
50 warning messages.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ Connection connection = new
CountDownConnection(getConnectionWithoutTracing(), latch);
+ traceWriterExtends = new TraceWriterExtends(generateUniqueName(),
defaultTracingThreadPoolForTest, defaultTracingBatchSizeForTest);
+ traceWriterExtends = new TraceWriterExtends(tableName,
defaultTracingThreadPoolForTest, defaultTracingBatchSizeForTest);
+ traceWriterExtends = new TraceWriterExtends(tableName,
defaultTracingThreadPoolForTest, defaultTracingBatchSizeForTest);
+ Span span = createNewSpan(traceid, Span.ROOT_SPAN_ID, 10, "root", 12,
13, "Some process", "test annotation for a span");
+ traceWriterExtends = new TraceWriterExtends(tableName,
defaultTracingThreadPoolForTest, defaultTracingBatchSizeForTest);
+ assertEquals("Didn't get expected annotation", count + " - " +
Bytes.toString(entry.getValue()),
+ traceWriterExtends = new TraceWriterExtends(tracingTableName,
defaultTracingThreadPoolForTest, defaultTracingBatchSizeForTest);
+ traceWriterExtends = new TraceWriterExtends(tracingTableName,
defaultTracingThreadPoolForTest, defaultTracingBatchSizeForTest);
+ traceWriterExtends = new TraceWriterExtends(tracingTableName,
defaultTracingThreadPoolForTest, defaultTracingBatchSizeForTest);
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/812//testReport/
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/812//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/812//console
This message is automatically generated.
> Remove hadoop metrics integration from the tracing framework
> ------------------------------------------------------------
>
> Key: PHOENIX-3752
> URL: https://issues.apache.org/jira/browse/PHOENIX-3752
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Samarth Jain
> Assignee: Karan Mehta
> Attachments: PHOENIX-3752.patch
>
>
> See discussion on PHOENIX-3062. We don't really need to use the hadoop
> metrics framework for writing traces to our trace table.
> [~karanmehta93] - let's use this JIRA instead of PHOENIX-3062. We can close
> that one once your this work is in.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
