[
https://issues.apache.org/jira/browse/PHOENIX-3752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014640#comment-16014640
]
Samarth Jain commented on PHOENIX-3752:
---------------------------------------
Thanks for the updated patch, [~karanmehta93]. Looks good except for the below
change which isn't correct:
{code}
+ @Override
+ public void receiveSpan(Span span) {
+ if (spanQueue.offer(span)) {
+ if (LOG.isTraceEnabled()) {
+ LOG.trace("Span buffered to queue " + span.toJson());
+ } else if (LOG.isDebugEnabled()) {
+ LOG.debug("Span NOT buffered due to overflow in queue " +
span.toJson());
+ }
+ }
+ }
{code}
The else block applies to outer if statement.
> Remove hadoop metrics integration from the tracing framework
> ------------------------------------------------------------
>
> Key: PHOENIX-3752
> URL: https://issues.apache.org/jira/browse/PHOENIX-3752
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Samarth Jain
> Assignee: Karan Mehta
> Attachments: PHOENIX-3752.002.patch, PHOENIX-3752.patch
>
>
> See discussion on PHOENIX-3062. We don't really need to use the hadoop
> metrics framework for writing traces to our trace table.
> [~karanmehta93] - let's use this JIRA instead of PHOENIX-3062. We can close
> that one once your this work is in.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
