[
https://issues.apache.org/jira/browse/PHOENIX-3818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15997522#comment-15997522
]
Hadoop QA commented on PHOENIX-3818:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12866200/PHOENIX-3818.v2.patch
against master branch at commit 5b099014446865c12779f3882fd8b407496717ea.
ATTACHMENT ID: 12866200
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
47 warning messages.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ Map<String, String> clientProps =
Collections.singletonMap(RpcControllerFactory.CUSTOM_CONTROLLER_CONF_KEY,
+ "CREATE TABLE " + tableName + " (k VARCHAR NOT NULL PRIMARY
KEY, v1 VARCHAR, v2 VARCHAR)");
+ PreparedStatement stmt = conn.prepareStatement("UPSERT INTO " +
tableName + " VALUES(?,?,?)");
+ private void upsertSelectRows(Connection conn, String tableName1, String
tableName2) throws SQLException {
+ runOnServer = (sameTable || serverUpsertSelectEnabled)
&& isAutoCommit && !table.isTransactional()
+ // If any pk slots are changing and server side UPSERT SELECT
is disabled, do not run on server
+ && !ExpressionUtil.isPkPositionChanging(new
TableRef(projectedTable), selectExpressions);
+ public static final String ENABLE_SERVER_UPSERT_SELECT
="phoenix.client.enable.server.upsert.select";
+ public static boolean isPkPositionChanging(TableRef tableRef,
List<Expression> projectedExpressions) throws SQLException {
+ .equals(new ColumnRef(tableRef,
column.getPosition()).newColumnExpression())) { return true; }
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/844//testReport/
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/844//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/844//console
This message is automatically generated.
> Add client setting to disable server side UPSERT SELECT work
> ------------------------------------------------------------
>
> Key: PHOENIX-3818
> URL: https://issues.apache.org/jira/browse/PHOENIX-3818
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.10.0
> Reporter: Alex Araujo
> Assignee: Alex Araujo
> Fix For: 4.11.0
>
> Attachments: PHOENIX-3818.v1.patch, PHOENIX-3818.v2.patch
>
>
> PHOENIX-3271 introduced RS -> RS RPCs by default via UPSERT SELECT
> statements. Add a client side setting that disables this behavior.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
