[
https://issues.apache.org/jira/browse/PHOENIX-2885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007017#comment-16007017
]
Maddineni Sukumar commented on PHOENIX-2885:
--------------------------------------------
Thanks [~apurtell] , my eye didn't catch that. Updated new patch with variable
name change.
And regarding test failures, I ran them multiple times and they are passing
passing locally, and I am sure this patch wont change anything related to above
failed tests.
This patch is to have configured default value and this unit tests covers all
three scenarios related to configuring value.
1. No configured default value which means update_cache_frequency=zero, create
table and assert update_cache_frequency=0
2. configure default value to some x and create table and assert table value to
x
3. With default value x create a table with table specific property
update_cache_frequency=y and assert table is created with value y.
I didn't add test to verify behavior of update_cache_frequency as that is
already tested code. And some of failures related to that are being fixed in
PHOENIX-3823 .
> Set default value for UPDATE_CACHE_FREQUENCY
> --------------------------------------------
>
> Key: PHOENIX-2885
> URL: https://issues.apache.org/jira/browse/PHOENIX-2885
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: James Taylor
> Assignee: Maddineni Sukumar
> Fix For: 4.11.0
>
> Attachments: PHOENIX-2885.4.10-HBase-0.98.patch, PHOENIX-2885.v2.patch
>
>
> We have the ability currently to tell Phoenix how stale we're will to have
> the metadata through our UPDATE_CACHE_FREQUENCY feature[1]. By default, when
> a table is created, unless explicitly specified, there is no
> UPDATE_CACHE_FREQUENCY set. We should provide a new Phoenix configuration
> parameter to specify a default value when a CREATE TABLE statement is
> executed. In addition, when a VIEW is created, we should inherit the
> UPDATE_CACHE_FREQUENCY value from the parent (unless it's explicitly
> specified) and then fallback to the new default config value.
> [1] https://phoenix.apache.org/language/index.html#options
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
