[
https://issues.apache.org/jira/browse/PHOENIX-2885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007019#comment-16007019
]
James Taylor commented on PHOENIX-2885:
---------------------------------------
[~apurtell] - FYI, we have UpdateCacheIT which verifies how many RPCs are made
with and without an UPDATE_CACHE_FREQUENCY being set.
Same question as Andrew on the test failures, [~sukuna...@gmail.com]. Couple of
other comments:
* We'll need a good way of getting better test coverage when we have a default
update cache frequency specified. One issue you already found was PHOENIX-3841
which is good, but we'll want to make sure there aren't other bugs lurking when
we turn this on. Where you thinking to add more unit tests with PHOENIX-3823?
Another possible way would be to parameterize some tests so that they run with
a default update cache frequency - we'd have to think about which sets of tests
this would make the most sense for.
* For the MetaDataClient changes, you'll want to get the parent update cache
frequency and use that if there's no update cache frequency specified on the
table directly and then only use the default update cache frequency if there's
no parent (that way, a view will have the same cache frequency update as it's
parent and an index will have the same cache frequency as the table it is on).
The precedence should work like this:
** first use value of update cache frequency specified directly on the table
{code}
Long ucfProp = (Long) TableProperty.UPDATE_CACHE_FREQUENCY.getValue(tableProps);
{code}
** second, {{if (ucfProp == null && parent != null)}} then should use the value
on the parent
{code}
ucfProp = parent.getUpdateCacheFrequency();
{code}
** otherwise, use the new default update cache frequency value
> Set default value for UPDATE_CACHE_FREQUENCY
> --------------------------------------------
>
> Key: PHOENIX-2885
> URL: https://issues.apache.org/jira/browse/PHOENIX-2885
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: James Taylor
> Assignee: Maddineni Sukumar
> Fix For: 4.11.0
>
> Attachments: PHOENIX-2885.4.10-HBase-0.98.patch, PHOENIX-2885.v2.patch
>
>
> We have the ability currently to tell Phoenix how stale we're will to have
> the metadata through our UPDATE_CACHE_FREQUENCY feature[1]. By default, when
> a table is created, unless explicitly specified, there is no
> UPDATE_CACHE_FREQUENCY set. We should provide a new Phoenix configuration
> parameter to specify a default value when a CREATE TABLE statement is
> executed. In addition, when a VIEW is created, we should inherit the
> UPDATE_CACHE_FREQUENCY value from the parent (unless it's explicitly
> specified) and then fallback to the new default config value.
> [1] https://phoenix.apache.org/language/index.html#options
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
