[
https://issues.apache.org/jira/browse/PHOENIX-3734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16009659#comment-16009659
]
Hadoop QA commented on PHOENIX-3734:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12867978/PHOENIX-3734.v2.patch
against master branch at commit 442d8eb29f1f73fd104a323d9aa77f3a4ccfd8d1.
ATTACHMENT ID: 12867978
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
49 warning messages.
{color:red}-1 release audit{color}. The applied patch generated 7 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ //TransactionAwareHTable txAware = new
TransactionAwareHTable(htable, TxConstants.ConflictDetection.ROW);
+ PhoenixTransactionContext txContext =
TransactionFactory.getTransactionFactory().getTransactionContext(pconn);
+ PhoenixTransactionalTable txTable =
TransactionFactory.getTransactionFactory().getTransactionalTable(txContext,
htable);
+ txTable =
TransactionFactory.getTransactionFactory().getTransactionalTable(txContext,
htable);
+ assertEquals(Boolean.TRUE.toString(),
admin.getTableDescriptor(TableName.valueOf(t2)).getValue(PhoenixTransactionContext.READ_NON_TX_DATA));
+ assertEquals(1000,
Integer.parseInt(colDesc.getValue(PhoenixTransactionContext.PROPERTY_TTL)));
+ assertEquals(1000,
Integer.parseInt(colDesc.getValue(PhoenixTransactionContext.PROPERTY_TTL)));
+ assertEquals(1000,
Integer.parseInt(colDesc.getValue(PhoenixTransactionContext.PROPERTY_TTL)));
+ assertEquals(1000,
Integer.parseInt(colDesc.getValue(PhoenixTransactionContext.PROPERTY_TTL)));
+ assertEquals(1000,
Integer.parseInt(colDesc.getValue(PhoenixTransactionContext.PROPERTY_TTL)));
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.iterate.ScannerLeaseRenewalIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexFailureIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/864//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/864//artifact/patchprocess/patchReleaseAuditWarnings.txt
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/864//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/864//console
This message is automatically generated.
> Refactor Phoenix to use TAL instead of direct calls to Tephra
> -------------------------------------------------------------
>
> Key: PHOENIX-3734
> URL: https://issues.apache.org/jira/browse/PHOENIX-3734
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Ohad Shacham
> Assignee: Ohad Shacham
> Attachments: PHOENIX-3734.v2.patch
>
>
> Refactor Phoenix to use the new transaction abstraction layer instead of
> direct calls to Tephra. Once this task will be committed, Phoenix will
> continue working with Tephra but will have the option for fast integration of
> new transaction processing engines.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
