[ https://issues.apache.org/jira/browse/PHOENIX-3822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012975#comment-16012975 ]
Hadoop QA commented on PHOENIX-3822: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12868382/PHOENIX-3822.patch against master branch at commit 442d8eb29f1f73fd104a323d9aa77f3a4ccfd8d1. ATTACHMENT ID: 12868382 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 13 new or modified tests. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 47 warning messages. {color:red}-1 release audit{color}. The applied patch generated 1 release audit warnings (more than the master's current 0 warnings). {color:red}-1 lineLengths{color}. The patch introduces the following lines longer than 100: + Pair<Long, Long> info = PhoenixRuntime.getEstimatedRowsBytesScannedForQuery(conn, sql, Lists.newArrayList()); + String sql = "SELECT ta.c1.a, ta.c2.b FROM " + tableA + " ta JOIN " + tableB + " tb ON ta.k = tb.k" ; + Pair<Long, Long> info = PhoenixRuntime.getEstimatedRowsBytesScannedForQuery(conn, sql, Lists.newArrayList()); + String sql = "SELECT /*+ USE_SORT_MERGE_JOIN */ ta.c1.a, ta.c2.b FROM " + tableA + " ta JOIN " + tableB + " tb ON ta.k = tb.k" ; + Pair<Long, Long> info = PhoenixRuntime.getEstimatedRowsBytesScannedForQuery(conn, sql, Lists.newArrayList()); + ParallelIteratorFactory parallelIteratorFactory, GroupBy groupBy, Expression having) throws SQLException { + Pair<Long, Long> p = ScanUtil.getEstimatedRowsAndBytesToScan(table.getTable(), context, table.getTable().getPhysicalName().getBytes()); + QueryPlan plan, HashJoinInfo joinInfo, SubPlan[] subPlans, boolean recompileWhereClause, List<SQLCloseable> dependencies) throws SQLException { + estimatedBytes = estimatedBytes == null ? subPlan.getInnerPlan().getEstimatedBytesToScan() : estimatedBytes + subPlan.getInnerPlan().getEstimatedBytesToScan(); + estimatedRows = estimatedRows == null ? subPlan.getInnerPlan().getEstimatedRowsToScan() : estimatedRows + subPlan.getInnerPlan().getEstimatedRowsToScan(); {color:red}-1 core tests{color}. The patch failed these unit tests: ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ViewIT Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/869//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/869//artifact/patchprocess/patchReleaseAuditWarnings.txt Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/869//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/869//console This message is automatically generated. > Surface byte and row estimates in a machine readable way when doing EXPLAIN > PLAN > -------------------------------------------------------------------------------- > > Key: PHOENIX-3822 > URL: https://issues.apache.org/jira/browse/PHOENIX-3822 > Project: Phoenix > Issue Type: Improvement > Reporter: Samarth Jain > Assignee: Samarth Jain > Attachments: PHOENIX-3822.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)