[ 
https://issues.apache.org/jira/browse/PHOENIX-3822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017002#comment-16017002
 ] 

Hadoop QA commented on PHOENIX-3822:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12868890/PHOENIX-3822_v3.patch
  against master branch at commit 21fb0b31b46da3b7cc27265467d83a1b4cd5c5c5.
  ATTACHMENT ID: 12868890

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 9 new 
or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 
47 warning messages.

    {color:red}-1 release audit{color}.  The applied patch generated 3 release 
audit warnings (more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +           String sql = "SELECT ta.c1.a, ta.c2.b FROM " + tableA + " ta 
JOIN " + tableB + " tb ON ta.k = tb.k" ;
+               String sql = "SELECT /*+ USE_SORT_MERGE_JOIN */ ta.c1.a, 
ta.c2.b FROM " + tableA + " ta JOIN " + tableB + " tb ON ta.k = tb.k" ;
+       private static Pair<Long, Long> getByteRowEstimates(Connection conn, 
String sql, List<Object> bindValues) throws Exception {
+     * @return estimated number of rows that will be scanned when this 
statement plan is been executed.
+     * @return estimated number of bytes that will be scanned when this 
statement plan is been executed.
+            ParallelIteratorFactory parallelIteratorFactory, GroupBy groupBy, 
Expression having) throws SQLException {
+        ExplainPlan exp = plan instanceof BaseQueryPlan ? new 
ExplainPlan(getPlanSteps(plan.iterator())) : plan.getExplainPlan();
+            QueryPlan plan, HashJoinInfo joinInfo, SubPlan[] subPlans, boolean 
recompileWhereClause, List<SQLCloseable> dependencies) throws SQLException {
+            Integer limit, Integer offset, OrderBy orderBy, 
ParallelIteratorFactory parallelIteratorFactory) throws SQLException {
+            Integer limit, Integer offset, OrderBy orderBy, 
ParallelIteratorFactory parallelIteratorFactory) throws SQLException {

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.ImmutableIndexWithStatsIT

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/881//testReport/
Release audit warnings: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/881//artifact/patchprocess/patchReleaseAuditWarnings.txt
Javadoc warnings: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/881//artifact/patchprocess/patchJavadocWarnings.txt
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/881//console

This message is automatically generated.

> Surface byte and row estimates in a machine readable way when doing EXPLAIN 
> PLAN
> --------------------------------------------------------------------------------
>
>                 Key: PHOENIX-3822
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3822
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Samarth Jain
>            Assignee: Samarth Jain
>         Attachments: PHOENIX-3822.patch, PHOENIX-3822_v2.patch, 
> PHOENIX-3822_v3.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to