[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014382#comment-16014382
]
Rahul Shrivastava commented on PHOENIX-3655:
--------------------------------------------
[~elserj],
According to me, the initial design was reasonable solution without the need to
make major changes to Phoenix metrics APIs. I think lets take James opinion on
this.
[~jamestaylor]
Josh suggests that we need to modify existing Phoenix metrics to link it to
Hadoop Metrics 2 system. This will give additional advantage of using existing
features of hadoop metrics 2. I am not too much well versed with design of
phoenix-metrics (probably [~samarthjain] will know better as he design the
original metrics).
The other choice is to is to develop as per option 1 mentioned in below design
doc.
https://issues.apache.org/jira/secure/attachment/12853221/MetricsforPhoenixQueryServerPQS.pdf.
I have written the code as per option 1 in the above design doc.
thanks
Rahul
> Metrics for PQS
> ---------------
>
> Key: PHOENIX-3655
> URL: https://issues.apache.org/jira/browse/PHOENIX-3655
> Project: Phoenix
> Issue Type: New Feature
> Affects Versions: 4.8.0
> Environment: Linux 3.13.0-107-generic kernel, v4.9.0-HBase-0.98
> Reporter: Rahul Shrivastava
> Assignee: Rahul Shrivastava
> Fix For: 4.9.0
>
> Attachments: MetricsforPhoenixQueryServerPQS.pdf
>
> Original Estimate: 240h
> Remaining Estimate: 240h
>
> Phoenix Query Server runs a separate process compared to its thin client.
> Metrics collection is currently done by PhoenixRuntime.java i.e. at Phoenix
> driver level. We need the following
> 1. For every jdbc statement/prepared statement/ run by PQS , we need
> capability to collect metrics at PQS level and push the data to external sink
> i.e. file, JMX , other external custom sources.
> 2. Besides this global metrics could be periodically collected and pushed to
> the sink.
> 2. PQS can be configured to turn on metrics collection and type of collect (
> runtime or global) via hbase-site.xml
> 3. Sink could be configured via an interface in hbase-site.xml.
> All metrics definition https://phoenix.apache.org/metrics.html
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
