[
https://issues.apache.org/jira/browse/PHOENIX-3752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16027284#comment-16027284
]
Samarth Jain commented on PHOENIX-3752:
---------------------------------------
I think Phoenix is going to support HBase-0.98 release for a while. Having said
that, I personally am ok with not making this change to the 0.98 branch.
[~karanmehta93], can you take a look at your patch again? It looks like the
tracing end to end tests are failing after this change.
{code}
[...truncated 77.79 KB...]
at
org.apache.phoenix.trace.PhoenixTracingEndToEndIT.testClientServerIndexingTracing(PhoenixTracingEndToEndIT.java:207)
testScanTracing(org.apache.phoenix.trace.PhoenixTracingEndToEndIT) Time
elapsed: 208.578 sec <<< FAILURE!
java.lang.AssertionError: Get expected updates to trace table
at
org.apache.phoenix.trace.PhoenixTracingEndToEndIT.testScanTracing(PhoenixTracingEndToEndIT.java:263)
testMultipleSpans(org.apache.phoenix.trace.PhoenixTracingEndToEndIT) Time
elapsed: 107.292 sec <<< FAILURE!
java.lang.AssertionError: Updates not written in table
at
org.apache.phoenix.trace.PhoenixTracingEndToEndIT.testMultipleSpans(PhoenixTracingEndToEndIT.java:488)
Tests run: 304, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1,917.994 sec
- in org.apache.phoenix.end2end.index.IndexIT
Results :
Failed tests:
PhoenixTracingEndToEndIT.testClientServerIndexingTracing:207 Never found
indexing updates
PhoenixTracingEndToEndIT.testMultipleSpans:488 Updates not written in table
PhoenixTracingEndToEndIT.testScanTracing:263 Get expected updates to trace
table
PhoenixTracingEndToEndIT.testSingleSpan:439 Updates not written in table
PhoenixTracingEndToEndIT.testWriteSpans:112 Sink not flushed. commit() not
called on the connection
{code}
> Remove hadoop metrics integration from the tracing framework
> ------------------------------------------------------------
>
> Key: PHOENIX-3752
> URL: https://issues.apache.org/jira/browse/PHOENIX-3752
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Samarth Jain
> Assignee: Karan Mehta
> Attachments: PHOENIX-3752.002.patch, PHOENIX-3752.003.patch,
> PHOENIX-3752.patch
>
>
> See discussion on PHOENIX-3062. We don't really need to use the hadoop
> metrics framework for writing traces to our trace table.
> [~karanmehta93] - let's use this JIRA instead of PHOENIX-3062. We can close
> that one once your this work is in.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
