[ https://issues.apache.org/jira/browse/PHOENIX-3612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035167#comment-16035167 ]
Hadoop QA commented on PHOENIX-3612: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12871019/PHOENIX-3612.patch against master branch at commit 9b8235eb8febbdee648d800eb578617023071dcc. ATTACHMENT ID: 12871019 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests. {color:red}-1 javac{color}. The patch appears to cause mvn compile goal to fail . Compilation errors resume: [ERROR] COMPILATION ERROR : [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixStatement.java:[1234,28] no suitable constructor found for MutationState(int,org.apache.phoenix.jdbc.PhoenixConnection) [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.0:compile (default-compile) on project phoenix-core: Compilation failure [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixStatement.java:[1234,28] no suitable constructor found for MutationState(int,org.apache.phoenix.jdbc.PhoenixConnection) [ERROR] constructor org.apache.phoenix.execute.MutationState.MutationState(org.apache.phoenix.schema.TableRef,java.util.Map<org.apache.phoenix.hbase.index.util.ImmutableBytesPtr,org.apache.phoenix.execute.MutationState.RowMutationState>,long,long,long,org.apache.phoenix.jdbc.PhoenixConnection) is not applicable [ERROR] (actual and formal argument lists differ in length) [ERROR] constructor org.apache.phoenix.execute.MutationState.MutationState(long,long,org.apache.phoenix.jdbc.PhoenixConnection,java.util.Map<org.apache.phoenix.schema.TableRef,java.util.Map<org.apache.phoenix.hbase.index.util.ImmutableBytesPtr,org.apache.phoenix.execute.MutationState.RowMutationState>>,org.apache.tephra.Transaction,org.apache.tephra.TransactionContext) is not applicable [ERROR] (actual and formal argument lists differ in length) [ERROR] constructor org.apache.phoenix.execute.MutationState.MutationState(long,long,org.apache.phoenix.jdbc.PhoenixConnection,org.apache.tephra.Transaction,org.apache.tephra.TransactionContext,long) is not applicable [ERROR] (actual and formal argument lists differ in length) [ERROR] constructor org.apache.phoenix.execute.MutationState.MutationState(long,long,org.apache.phoenix.jdbc.PhoenixConnection,org.apache.tephra.Transaction,org.apache.tephra.TransactionContext) is not applicable [ERROR] (actual and formal argument lists differ in length) [ERROR] constructor org.apache.phoenix.execute.MutationState.MutationState(long,long,org.apache.phoenix.jdbc.PhoenixConnection,long) is not applicable [ERROR] (actual and formal argument lists differ in length) [ERROR] constructor org.apache.phoenix.execute.MutationState.MutationState(org.apache.phoenix.execute.MutationState) is not applicable [ERROR] (actual and formal argument lists differ in length) [ERROR] constructor org.apache.phoenix.execute.MutationState.MutationState(long,long,org.apache.phoenix.jdbc.PhoenixConnection,org.apache.tephra.TransactionContext) is not applicable [ERROR] (actual and formal argument lists differ in length) [ERROR] constructor org.apache.phoenix.execute.MutationState.MutationState(long,long,org.apache.phoenix.jdbc.PhoenixConnection) is not applicable [ERROR] (actual and formal argument lists differ in length) [ERROR] [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException [ERROR] [ERROR] After correcting the problems, you can resume the build with the command [ERROR] mvn <goals> -rf :phoenix-core Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/988//console This message is automatically generated. > Make tracking of max allowed number of mutations bytes based instead of row > based > --------------------------------------------------------------------------------- > > Key: PHOENIX-3612 > URL: https://issues.apache.org/jira/browse/PHOENIX-3612 > Project: Phoenix > Issue Type: Bug > Reporter: James Taylor > Assignee: Thomas D'Silva > Fix For: 4.11.0 > > Attachments: PHOENIX-3612.patch > > > Some remaining work related to PHOENIX-541 to track the byte-size of all > mutations being buffered instead of the number of rows: > - Make similar changes QueryServices.MAX_MUTATION_SIZE_ATTRIB - making it > byte-based instead of row-count-based. Usage of this config parameter would > be isolated to MutationState, I believe. We should be able to come up with an > accurate size based on the underlying Mutation and/or Delete info we store in > PRowImpl. > - Have a reasonable (smaller) default for the new > QueryServices.MAX_MUTATION_SIZE_BYTES_ATTRIB > This is essentially a guard on the memory usage. It could potentially > leverage our MemoryManager. -- This message was sent by Atlassian JIRA (v6.3.15#6346)