[
https://issues.apache.org/jira/browse/PHOENIX-3612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035377#comment-16035377
]
Hadoop QA commented on PHOENIX-3612:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12871028/PHOENIX-3612-v2-master.patch
against master branch at commit 9b8235eb8febbdee648d800eb578617023071dcc.
ATTACHMENT ID: 12871028
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
45 warning messages.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ PhoenixConnection connection = (PhoenixConnection)
DriverManager.getConnection(getUrl(), connectionProperties);
+
assertEquals(SQLExceptionCode.MAX_MUTATION_SIZE_EXCEEDED.getErrorCode(),
e.getErrorCode());
+ connection = (PhoenixConnection) DriverManager.getConnection(getUrl(),
connectionProperties);
+
assertEquals(SQLExceptionCode.MAX_MUTATION_SIZE_BYTES_EXCEEDED.getErrorCode(),
e.getErrorCode());
+ final int maxSizeBytes =
services.getProps().getInt(QueryServices.MAX_MUTATION_SIZE_BYTES_ATTRIB,QueryServicesOptions.DEFAULT_MAX_MUTATION_SIZE_BYTES);
+ MutationState state = new MutationState(targetTableRef,
mutations, 0, maxSize, maxSizeBytes, connection);
+ MutationState indexState = new
MutationState(indexTableRefs.get(i), indexMutations.get(i), 0, maxSize,
maxSizeBytes, connection);
+ MutationState state = new MutationState(targetTableRef, mutations,
nCommittedRows, maxSize, maxSizeBytes, connection);
+ MutationState indexState = new
MutationState(indexTableRefs.get(i), indexMutations.get(i), 0, maxSize,
maxSizeBytes, connection);
+ final int maxSizeBytes =
services.getProps().getInt(QueryServices.MAX_MUTATION_SIZE_BYTES_ATTRIB,QueryServicesOptions.DEFAULT_MAX_MUTATION_SIZE_BYTES);
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.UpgradeIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.trace.PhoenixTracingEndToEndIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/989//testReport/
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/989//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/989//console
This message is automatically generated.
> Make tracking of max allowed number of mutations bytes based instead of row
> based
> ---------------------------------------------------------------------------------
>
> Key: PHOENIX-3612
> URL: https://issues.apache.org/jira/browse/PHOENIX-3612
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: Thomas D'Silva
> Fix For: 4.11.0
>
> Attachments: PHOENIX-3612.patch, PHOENIX-3612-v2-master.patch
>
>
> Some remaining work related to PHOENIX-541 to track the byte-size of all
> mutations being buffered instead of the number of rows:
> - Make similar changes QueryServices.MAX_MUTATION_SIZE_ATTRIB - making it
> byte-based instead of row-count-based. Usage of this config parameter would
> be isolated to MutationState, I believe. We should be able to come up with an
> accurate size based on the underlying Mutation and/or Delete info we store in
> PRowImpl.
> - Have a reasonable (smaller) default for the new
> QueryServices.MAX_MUTATION_SIZE_BYTES_ATTRIB
> This is essentially a guard on the memory usage. It could potentially
> leverage our MemoryManager.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
