[
https://issues.apache.org/jira/browse/PHOENIX-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16095326#comment-16095326
]
James Taylor commented on PHOENIX-3525:
---------------------------------------
One quick note on the lock acquisition strategy. Yes, we absolutely want to
wait if the lock can't be acquired, and we actually are waiting. The javadoc is
wrong for Region (and I thought they fixed that as we had a long discussion in
HBase land on this a while back - maybe I don't have the latest source code).
The boolean argument actually determines if you want a non exclusive read lock
(true) or an exclusive write lock. See the HRegion.getRowLock implementation:
{code}
/**
*
* Get a row lock for the specified row. All locks are reentrant.
*
* Before calling this function make sure that a region operation has already
been
* started (the calling thread has already acquired the region-close-guard
lock).
* @param row The row actions will be performed against
* @param readLock is the lock reader or writer. True indicates that a
non-exlcusive
* lock is requested
*/
@Override
public RowLock getRowLock(byte[] row, boolean readLock) throws IOException {
{code}
We should check the code and javadoc in the 0.98 branch to verify too.
I'll review other parts of the patch shortly, but please leave the getRowLock
call as is.
> Cap automatic index rebuilding to inactive timestamp.
> -----------------------------------------------------
>
> Key: PHOENIX-3525
> URL: https://issues.apache.org/jira/browse/PHOENIX-3525
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Ankit Singhal
> Attachments: PHOENIX-3525_wip.patch
>
>
> From [[email protected]] review comment on
> https://github.com/apache/phoenix/pull/210
> For automatic rebuilding ,DISABLED_TIMESTAMP is lower bound but there is no
> upper bound so we are going rebuild all the new writes written after
> DISABLED_TIMESTAMP even though indexes updated properly. So we can introduce
> an upper bound of time where we are going to start a rebuild thread so we can
> limit the data to rebuild. In case If there are frequent writes then we can
> increment the rebuild period exponentially
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
