[
https://issues.apache.org/jira/browse/PHOENIX-4150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16152920#comment-16152920
]
Ethan Wang commented on PHOENIX-4150:
-------------------------------------
[~jamestaylor] per we discussed, I added property checking at
PhoenixConnection. This will allow user to define the whitelisted properties vs
blacklisted properties however they want. Please review. Thanks!
Two notes,
1, assuming all phoenix properties will have string as key;
2, regarding naming, "PropertyPolicy" vs "PropertyPolicyFactory", I used
former. Since this class is providing a method (service), rather than a object.
+[~alexaraujo]
> Adding a policy filter to whitelist the properties that allow to be passed to
> Phoenix
> -------------------------------------------------------------------------------------
>
> Key: PHOENIX-4150
> URL: https://issues.apache.org/jira/browse/PHOENIX-4150
> Project: Phoenix
> Issue Type: Bug
> Reporter: Ethan Wang
> Assignee: Ethan Wang
> Attachments: PHOENIX-4150-v1.patch
>
>
> Adding a policy filter to whitelist the properties that allow to be passed to
> Phoenix.
> Feature proposal:
> When user getting phoenix connection via
> Connection conn = DriverManager.getConnection(connectionString, properties);
> A properties whitelist policy will essentially check each properties that
> passed in (likely happen at PhoenixDriver.java), so that the un-allowed
> property will result in an exception been thrown.
> Similar to HBaseFactoryProvider, proposing have a interface for whitelist
> policy and a default impl that will by default allow all properties. User can
> override the impl for this interface to start using whitelist feature
> [~jamestaylor] [~alexaraujo]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
