[
https://issues.apache.org/jira/browse/PHOENIX-4150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16158080#comment-16158080
]
Hadoop QA commented on PHOENIX-4150:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12885972/PHOENIX-4150-v3.patch
against master branch at commit 5a21734f10a90fa8de0dce390aedc8edeb52b26c.
ATTACHMENT ID: 12885972
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 10 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 3 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ * if (propertiesKeyDisAllowed.contains(k))
offendingProperties.put((String)k,properties.getProperty((String)k));
+ * if (offendingProperties.size()>0) throw new
IllegalArgumentException("properties not allowed. offending properties" +
offendingProperties);
+ * Dependent modules may register their own implementations of the following
using {@link java.util.ServiceLoader}:
+ private static final PropertyPolicy DEFAULT_PROPERTY_POLICY = new
PropertyPolicy.PropertyPolicyImpl();
+ if (propertiesKeyDisAllowed.contains(k))
offendingProperties.put((String)k,properties.getProperty((String)k));
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ViewIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1408//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1408//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1408//console
This message is automatically generated.
> Adding a policy filter to whitelist the properties that allow to be passed to
> Phoenix
> -------------------------------------------------------------------------------------
>
> Key: PHOENIX-4150
> URL: https://issues.apache.org/jira/browse/PHOENIX-4150
> Project: Phoenix
> Issue Type: Bug
> Reporter: Ethan Wang
> Assignee: Ethan Wang
> Priority: Critical
> Attachments: PHOENIX-4150-v1.patch, PHOENIX-4150-v2.patch,
> PHOENIX-4150-v3.patch
>
>
> Adding a policy filter to whitelist the properties that allow to be passed to
> Phoenix.
> Feature proposal:
> When user getting phoenix connection via
> Connection conn = DriverManager.getConnection(connectionString, properties);
> A properties whitelist policy will essentially check each properties that
> passed in (likely happen at PhoenixDriver.java), so that the un-allowed
> property will result in an exception been thrown.
> Similar to HBaseFactoryProvider, proposing have a interface for whitelist
> policy and a default impl that will by default allow all properties. User can
> override the impl for this interface to start using whitelist feature
> [~jamestaylor] [~alexaraujo]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
