[
https://issues.apache.org/jira/browse/PHOENIX-4150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159473#comment-16159473
]
Hadoop QA commented on PHOENIX-4150:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12886157/PHOENIX-4150-v4-nit.patch
against master branch at commit 481440d08a409de4067619d3a7cd333eeef6e717.
ATTACHMENT ID: 12886157
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 7 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1410//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1410//console
This message is automatically generated.
> Adding a policy filter to whitelist the properties that allow to be passed to
> Phoenix
> -------------------------------------------------------------------------------------
>
> Key: PHOENIX-4150
> URL: https://issues.apache.org/jira/browse/PHOENIX-4150
> Project: Phoenix
> Issue Type: Bug
> Reporter: Ethan Wang
> Assignee: Ethan Wang
> Priority: Critical
> Attachments: PHOENIX-4150-v1.patch, PHOENIX-4150-v2.patch,
> PHOENIX-4150-v3.patch, PHOENIX-4150-v4-nit.patch
>
>
> Adding a policy filter to whitelist the properties that allow to be passed to
> Phoenix.
> Feature proposal:
> When user getting phoenix connection via
> Connection conn = DriverManager.getConnection(connectionString, properties);
> A properties whitelist policy will essentially check each properties that
> passed in (likely happen at PhoenixDriver.java), so that the un-allowed
> property will result in an exception been thrown.
> Similar to HBaseFactoryProvider, proposing have a interface for whitelist
> policy and a default impl that will by default allow all properties. User can
> override the impl for this interface to start using whitelist feature
> [~jamestaylor] [~alexaraujo]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
