[
https://issues.apache.org/jira/browse/PHOENIX-4230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16180156#comment-16180156
]
Hadoop QA commented on PHOENIX-4230:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12888979/PHOENIX-4230_v2.patch
against master branch at commit 944bed73585a5ff826997895c2da43720b229d8a.
ATTACHMENT ID: 12888979
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ // lower the number of rpc retries. We inherit config from
HConnectionManager#setServerSideHConnectionRetries,
+ // which by default uses a multiplier of 10. That is too many retries
for our synchronous index writes
+ context.indexUpdates = getIndexUpdates(c.getEnvironment(),
indexMetaData, getMutationIterator(miniBatchOp), txRollbackAttribute);
+ MiniBatchOperationInProgress<Mutation> miniBatchOp, final boolean
success) throws IOException {
+ private void
setBatchMutateContext(ObserverContext<RegionCoprocessorEnvironment> c,
BatchMutateContext context) {
+ private BatchMutateContext
getBatchMutateContext(ObserverContext<RegionCoprocessorEnvironment> c) {
+ private static void addMutation(Map<ImmutableBytesPtr, MultiMutation>
mutations, ImmutableBytesPtr row, Mutation m) {
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.QueryWithTableSampleIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1477//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1477//console
This message is automatically generated.
> Write index updates in postBatchMutateIndispensably for transactional tables
> ----------------------------------------------------------------------------
>
> Key: PHOENIX-4230
> URL: https://issues.apache.org/jira/browse/PHOENIX-4230
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: James Taylor
> Attachments: PHOENIX-4230.patch, PHOENIX-4230_v2.patch
>
>
> This change was already made for non transactional tables. We should make the
> same change for transactional tables to prevent RPCs while rows are locked.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
