[
https://issues.apache.org/jira/browse/PHOENIX-4342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16236851#comment-16236851
]
Hadoop QA commented on PHOENIX-4342:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12895489/PHOENIX-4342.patch
against master branch at commit 8f9356a2bdd6ba603158899eba38750c85e8e574.
ATTACHMENT ID: 12895489
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ List<DeleteMutationPlan> mutationPlans =
Lists.newArrayListWithExpectedSize(queryPlans.size());
+ mutationPlans.add(new SingleRowDeleteMutationPlan(dataPlan,
connection, maxSize, maxSizeBytes));
+ return new ServerSelectDeleteMutationPlan(dataPlan, connection,
aggPlan, projector, maxSize, maxSizeBytes);
+ return new ClientSelectDeleteMutationPlan(targetTableRef,
dataPlan, bestPlan, hasPreOrPostProcessing,
+ parallelIteratorFactory, otherTableRefs,
projectedTableRef, maxSize, maxSizeBytes, connection);
+ public SingleRowDeleteMutationPlan(QueryPlan dataPlan,
PhoenixConnection connection, int maxSize, int maxSizeBytes) {
+ Map<ImmutableBytesPtr,RowMutationState> mutation =
Maps.newHashMapWithExpectedSize(ranges.getPointLookupCount());
+ mutation.put(new
ImmutableBytesPtr(iterator.next().getLowerRange()), new
RowMutationState(PRow.DELETE_MARKER,
statement.getConnection().getStatementExecutionCounter(),
NULL_ROWTIMESTAMP_INFO, null));
+ return new MutationState(context.getCurrentTable(), mutation, 0,
maxSize, maxSizeBytes, connection);
+ public ServerSelectDeleteMutationPlan(QueryPlan dataPlan,
PhoenixConnection connection, QueryPlan aggPlan,
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1608//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1608//console
This message is automatically generated.
> Surface QueryPlan in MutationPlan
> ---------------------------------
>
> Key: PHOENIX-4342
> URL: https://issues.apache.org/jira/browse/PHOENIX-4342
> Project: Phoenix
> Issue Type: Improvement
> Reporter: James Taylor
> Assignee: Geoffrey Jacoby
> Priority: Minor
> Attachments: PHOENIX-4342.patch
>
>
> For DELETE statements, it'd be good to be able to get at the QueryPlan
> through the MutationPlan so we can get more structured information at compile
> time.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
