[
https://issues.apache.org/jira/browse/PHOENIX-4342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238554#comment-16238554
]
James Taylor commented on PHOENIX-4342:
---------------------------------------
+1 with one minor nit on patch. Do we still need firstPlan as a member variable
here?
{code}
+ private class MultiRowDeleteMutationPlan implements MutationPlan {
private final List<MutationPlan> plans;
private final MutationPlan firstPlan;
-
- public MultiDeleteMutationPlan(@NotNull List<MutationPlan> plans) {
+ private final QueryPlan dataPlan;
+
+ public MultiRowDeleteMutationPlan(QueryPlan dataPlan, @NotNull
List<MutationPlan> plans) {
Preconditions.checkArgument(!plans.isEmpty());
this.plans = plans;
this.firstPlan = plans.get(0);
+ this.dataPlan = dataPlan;
}
{code}
> Surface QueryPlan in MutationPlan
> ---------------------------------
>
> Key: PHOENIX-4342
> URL: https://issues.apache.org/jira/browse/PHOENIX-4342
> Project: Phoenix
> Issue Type: Improvement
> Reporter: James Taylor
> Assignee: Geoffrey Jacoby
> Priority: Minor
> Attachments: PHOENIX-4342-v2.patch, PHOENIX-4342-v3.patch,
> PHOENIX-4342-v4.patch, PHOENIX-4342.patch
>
>
> For DELETE statements, it'd be good to be able to get at the QueryPlan
> through the MutationPlan so we can get more structured information at compile
> time.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
