Fine by me too. Let me put up a patch now, and we can make the call
(either way, patch will still be valid)
On 11/6/17 2:35 PM, Andrew Purtell wrote:
I think LICENSE, NOTICE, and other legally required aspects of ASF
packaging is the critically important things to get right with a release,
so let's fix this. Should be quick to do and if the only change then
everyone should be comfortable carrying forward their votes based on
functional testing.
On Mon, Nov 6, 2017 at 9:18 AM, Josh Elser <[email protected]> wrote:
Thanks for the correction, James. This wasn't added to
dependencyManagement, so I missed it.
The Salesforce copyright notice (https://github.com/salesforce
/i18n-util/blob/master/LICENSE.txt) should be propagated to our
binary-release's NOTICE file (dev/release_files/NOTICE) and the project
name should be listed with the rest of the 3-clause BSD-licensed
dependencies we bundle in our LICENSE file (also in dev/release_files).
Three small things to fix for this -- if nothing else is found wrong in
rc0, (IMO) fix it for the next release.
On 11/3/17 11:57 PM, James Taylor wrote:
Thanks for the vote, Josh, but FYI there is a new dependency
with com.salesforce.i18n:i18n-util that went in with PHOENIX-4237.
On Fri, Nov 3, 2017 at 8:23 PM, Josh Elser <[email protected]> wrote:
+1 (binding)
* Can build from source and run unit tests
* No new deps since 4.12 (implies L&N is still good)
* 4.13 tags are deployed and match
* No unexpected files in src releases
On 11/3/17 6:21 PM, James Taylor wrote:
Hello Everyone,
This is a call for a vote on Apache Phoenix 4.13.0 RC0. This is the next
minor release of Phoenix 4, compatible with Apache HBase 0.98 and 1.3.
The
release includes both a source-only release and a convenience binary
release for each supported HBase version.
This release has feature parity with supported HBase versions and
includes
the following improvements:
- Critical bug fix to prevent snapshot creation of SYSTEM.CATALOG when
connecting [1]
- Numerous bug fixes around handling of row deletion [2][3][4][5]
- Improvements to statistics collection [6][7][8][9]
- New COLLATION_KEY built-in function for linguistic sort [10]
The source tarball, including signatures, digests, etc can be found at:
https://dist.apache.org/repos/dist/dev/phoenix/apache-phoeni
x-4.13.0-HBase-0.98-rc0/src/
https://dist.apache.org/repos/dist/dev/phoenix/apache-phoeni
x-4.13.0-HBase-1.3-rc0/src/
The binary artifacts can be found at:
https://dist.apache.org/repos/dist/dev/phoenix/apache-phoeni
x-4.13.0-HBase-0.98-rc0/bin/
https://dist.apache.org/repos/dist/dev/phoenix/apache-phoeni
x-4.13.0-HBase-1.3-rc0/bin/
For a complete list of changes, see:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
ctId=12315120&version=12341710
Release artifacts are signed with the following key:
https://people.apache.org/keys/committer/mujtaba.asc
https://dist.apache.org/repos/dist/release/phoenix/KEYS
The hash and tag to be voted upon:
https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=comm
it;h=7e795ac67fd21bd48f49acda3327c83d369aead4
https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=tag;
h=refs/tags/v4.13.0-HBase-0.98-rc0
https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=comm
it;h=a09cea6bfb94edd95ce06aa2cb7f229227db5666
https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=tag;
h=refs/tags/v4.13.0-HBase-1.3-rc0
The hash and tag to be voted upon:
https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=comm
it;h=13a7f97b49704642d67481c58a118a68c2e4c2e5
https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=tag;
h=refs/tags/v4.12.0-HBase-0.98-rc0
https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=comm
it;h=e40bbfff1150e56e1ecb7cd22c49cee298496c2b
https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=tag;
h=refs/tags/v4.12.0-HBase-1.1-rc0
https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=comm
it;h=d79dd50ff732f2673e1414d970cd4742e2c135de
https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=tag;
h=refs/tags/v4.12.0-HBase-1.2-rc0
https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=comm
it;h=f0bc4cdb5bbf96b316c78cc816400b04f63e911b
https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=tag;
h=refs/tags/v4.12.0-HBase-1.3-rc0
Vote will be open for at least 72 hours. Please vote:
[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove (and reason why)
Thanks,
The Apache Phoenix Team
[1] https://issues.apache.org/jira/browse/PHOENIX-4335
[2] https://issues.apache.org/jira/browse/PHOENIX-4280
[3] https://issues.apache.org/jira/browse/PHOENIX-4290
[4] https://issues.apache.org/jira/browse/PHOENIX-4348
[5] https://issues.apache.org/jira/browse/PHOENIX-4277
[6] https://issues.apache.org/jira/browse/PHOENIX-3368
[7] https://issues.apache.org/jira/browse/PHOENIX-4287
[8] https://issues.apache.org/jira/browse/PHOENIX-4289
[9] https://issues.apache.org/jira/browse/PHOENIX-4343
[10] https://issues.apache.org/jira/browse/PHOENIX-4237
