[
https://issues.apache.org/jira/browse/PHOENIX-4318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16249943#comment-16249943
]
Anoop Sam John commented on PHOENIX-4318:
-----------------------------------------
bq. There is no public constructor to create StoreScanner from list of
StoreFileScanners except for compaction. should we use selectScannersFrom() but
it is also annotated as visibleForTesting ?
StoreScanner is private. Why to create this Object on ur own?
bq.preCompactScannerOpen() doesn't allow to return scanner, can I use
preCompact() hook to change the scanner?
Yes. I hope u want to wrap the original one.
Its really getting tough to have a StoreFileReader version of ur own. I know
why Phoenix is having one. We should see whether/how we can avoid this.
bq.preStoreScannerOpen doesn't allow to return scanner now, is there any
alternatives to change StoreScanners?
Why? What want to do with StoreScanners? I think this and 1st Q are related.
We dont expect CP users to create own StoreScanner object. Not giving a way
just to change the Store level scanner. The wrap can be done at higher level at
Region scanner layer alone now. What is the usage to just handle one Store for
this Store scanner?
> Fix IndexHalfStoreFileReader and related classes
> ------------------------------------------------
>
> Key: PHOENIX-4318
> URL: https://issues.apache.org/jira/browse/PHOENIX-4318
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Ankit Singhal
> Assignee: Ankit Singhal
> Labels: HBase-2.0
> Fix For: 4.14.0
>
> Attachments: PHOENIX-4318_wip.patch, PHOENIX-4318_wip3.patch
>
>
> These classes use the internals of HBase.(And most of them are not accessible
> in HBase 2.0)
> phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/LocalIndexStoreFileScanner.java
> phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexHalfStoreFileReader.java
> phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexHalfStoreFileReaderGenerator.java
> phoenix-core/src/main/java/org/apache/phoenix/coprocessor/DelegateRegionScanner.java
> phoenix-core/src/main/java/org/apache/phoenix/util/IndexUtil.java
> phoenix-core/src/main/java/org/apache/phoenix/coprocessor/DelegateRegionObserver.java
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
