[ 
https://issues.apache.org/jira/browse/PHOENIX-4318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251079#comment-16251079
 ] 

Ankit Singhal commented on PHOENIX-4318:
----------------------------------------

Thanks [~anoop.hbase] for the confirmation. Actually, this is how currently the 
local index implemented. 
bq. Its really getting tough to have a StoreFileReader version of our own. I 
know why Phoenix is having one. We should see whether/how we can avoid this.
bq. We don't expect CP users to create own StoreScanner object. Not giving a 
way just to change the Store level scanner. The wrap can be done at a higher 
level at Region scanner layer alone now. What is the usage to just handle one 
Store for this Store scanner?
[~rajeshbabu],  as you more aware of local index implementation, assigning to 
you for making the changes from here onwards.


> Fix IndexHalfStoreFileReader and related classes
> ------------------------------------------------
>
>                 Key: PHOENIX-4318
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4318
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Ankit Singhal
>            Assignee: Ankit Singhal
>              Labels: HBase-2.0
>             Fix For: 4.14.0
>
>         Attachments: PHOENIX-4318_wip.patch, PHOENIX-4318_wip3.patch
>
>
> These classes use the internals of HBase.(And most of them are not accessible 
> in HBase 2.0)
> phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/LocalIndexStoreFileScanner.java
> phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexHalfStoreFileReader.java
> phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexHalfStoreFileReaderGenerator.java
> phoenix-core/src/main/java/org/apache/phoenix/coprocessor/DelegateRegionScanner.java
> phoenix-core/src/main/java/org/apache/phoenix/util/IndexUtil.java
> phoenix-core/src/main/java/org/apache/phoenix/coprocessor/DelegateRegionObserver.java



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to