[ 
https://issues.apache.org/jira/browse/PHOENIX-672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271848#comment-16271848
 ] 

Hadoop QA commented on PHOENIX-672:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12899867/PHOENIX-672.003.patch
  against master branch at commit 355ee522c1d4ff07cf9fbb0a9a01e43e3f702730.
  ATTACHMENT ID: 12899867

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 3 release 
audit warnings (more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +            "SYSTEM.\"CATALOG\"", "SYSTEM.\"SEQUENCE\"", 
"SYSTEM.\"STATS\"", "SYSTEM.\"FUNCTION\""));
+            QueryConstants.SYSTEM_SCHEMA_NAME + "." + "\"" + 
PhoenixDatabaseMetaData.SYSTEM_SEQUENCE_TABLE+ "\"";
+    // DON'T USE HADOOP UserGroupInformation class to create testing users 
since HBase misses some of its functionality
+        groupUser = User.createUserForTesting(testUtil.getConfiguration(), 
"groupUser", new String[] {GROUP_SYSTEM_ACCESS});
+        unprivilegedUser = User.createUserForTesting(configuration, 
"unprivilegedUser", new String[0]);
+        config.set("hbase.regionserver.wal.codec", 
"org.apache.hadoop.hbase.regionserver.wal.IndexedWALEditCodec");
+    @Parameterized.Parameters(name = "isNamespaceMapped={0}") // name is used 
by failsafe as file name in reports
+    void grantPermissions(String toUser, Set<String> tablesToGrant, 
Permission.Action... actions) throws Throwable {
+            AccessControlClient.grant(getUtility().getConnection(), 
TableName.valueOf(table), toUser, null, null,
+    void grantPermissions(String toUser, String namespace, 
Permission.Action... actions) throws Throwable {

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.execute.PartialCommitIT

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1640//testReport/
Release audit warnings: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1640//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1640//console

This message is automatically generated.

> Add GRANT and REVOKE commands using HBase AccessController
> ----------------------------------------------------------
>
>                 Key: PHOENIX-672
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-672
>             Project: Phoenix
>          Issue Type: Task
>            Reporter: James Taylor
>            Assignee: Karan Mehta
>              Labels: namespaces, security
>             Fix For: 4.14.0
>
>         Attachments: PHOENIX-672.001.patch, PHOENIX-672.002.patch, 
> PHOENIX-672.003.patch
>
>
> In HBase 0.98, cell-level security will be available. Take a look at 
> [this](https://communities.intel.com/community/datastack/blog/2013/10/29/hbase-cell-security)
>  excellent blog post by @apurtell. Once Phoenix works on 0.96, we should add 
> support for security to our SQL grammar.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to