[
https://issues.apache.org/jira/browse/PHOENIX-2715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16429927#comment-16429927
]
Josh Elser commented on PHOENIX-2715:
-------------------------------------
Thanks for the updated patch (on the weekend too)! Will test-drive it too.
{quote} * If not an alternate implementation of LogWriter, at least a better
factoring. Make LogWriter abstract or an interface. That should be quickly
accomplished.{quote}
I think this is a good suggestion for an initial implementation. Since we're
starting out fresh, putting the abstraction points in there now would help. A
LogWriter interface would be great.
{quote}Can we have a knob for probabilistic sampling? This is really easy to
implement. Add one config parameter, a float or double, one that can ideally be
changed dynamically.
{quote}
I like this too. Great suggestion on implementation detail too, Andrew :)
> Query Log
> ---------
>
> Key: PHOENIX-2715
> URL: https://issues.apache.org/jira/browse/PHOENIX-2715
> Project: Phoenix
> Issue Type: New Feature
> Reporter: Nick Dimiduk
> Assignee: Ankit Singhal
> Priority: Major
> Attachments: PHOENIX-2715.patch, PHOENIX-2715_master.patch,
> PHOENIX-2715_master_V1.patch
>
>
> One useful feature of other database systems is the query log. It allows the
> DBA to review the queries run, who's run them, time taken, &c. This serves
> both as an audit and also as a source of "ground truth" for performance
> optimization. For instance, which columns should be indexed. It may also
> serve as the foundation for automated performance recommendations/actions.
> What queries are being run is the first piece. Have this data tied into
> tracing results and perhaps client-side metrics (PHOENIX-1819) becomes very
> useful.
> This might take the form of clients writing data to a new system table, but
> other implementation suggestions are welcome.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
