Josh Elser commented on PHOENIX-2715:

Great! I got this working locally with your updated patch. Thanks again, Ankit!

One more thing: did we discuss at some point about not logging system table 
queries? I'm noticing that I get ~4 entries in system.log for every one query I 
run in sqlline against a user table.

I think making a quick pass to ensure some good Interfaces exist should be done 
before an initial commit. It would be nice to see the sampling but I think that 
could be done follow-on (not sure if Andrew feels strongly one way or the 
other). Pruning out system table queries (or maybe having an option to prune 
them) would be a nice-to-have follow-on – my guess is that it's hard to 
identify these queries.

> Query Log
> ---------
>                 Key: PHOENIX-2715
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2715
>             Project: Phoenix
>          Issue Type: New Feature
>            Reporter: Nick Dimiduk
>            Assignee: Ankit Singhal
>            Priority: Major
>         Attachments: PHOENIX-2715.patch, PHOENIX-2715_master.patch, 
> PHOENIX-2715_master_V1.patch
> One useful feature of other database systems is the query log. It allows the 
> DBA to review the queries run, who's run them, time taken, &c. This serves 
> both as an audit and also as a source of "ground truth" for performance 
> optimization. For instance, which columns should be indexed. It may also 
> serve as the foundation for automated performance recommendations/actions.
> What queries are being run is the first piece. Have this data tied into 
> tracing results and perhaps client-side metrics (PHOENIX-1819) becomes very 
> useful.
> This might take the form of clients writing data to a new system table, but 
> other implementation suggestions are welcome.

This message was sent by Atlassian JIRA

Reply via email to