[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16479635#comment-16479635
]
Josh Elser commented on PHOENIX-3655:
-------------------------------------
{quote}The stuff you are talking about is implemented as a part of
hbase-hadoop2-compat library on which phoenix-core depends. I would prefer
re-using the code that provides the {{HBaseMetrics2HadoopMetricsAdapter}} for
converting the metrics. Also, {{GlobalMetricRegistriesAdapter}} class helps me
directly dump the hbase registry to JMX.
{quote}
Maybe we're talking past each other. I am talking about the classes/interfaces
defined in hbase-metrics-api. These classes/interfaces are what
HBaseMetrics2HadopMetricsAdapter uses and I think that is what would be good to
use. BaseSourceImpl is not a part of this collection. I am suggesting that
Phoenix depend on nothing metrics-related in hbase-hadoop2-compat.
> Metrics for PQS
> ---------------
>
> Key: PHOENIX-3655
> URL: https://issues.apache.org/jira/browse/PHOENIX-3655
> Project: Phoenix
> Issue Type: New Feature
> Affects Versions: 4.8.0
> Environment: Linux 3.13.0-107-generic kernel, v4.9.0-HBase-0.98
> Reporter: Rahul Shrivastava
> Assignee: Karan Mehta
> Priority: Major
> Fix For: 4.15.0
>
> Attachments: MetricsforPhoenixQueryServerPQS.pdf
>
> Original Estimate: 240h
> Remaining Estimate: 240h
>
> Phoenix Query Server runs a separate process compared to its thin client.
> Metrics collection is currently done by PhoenixRuntime.java i.e. at Phoenix
> driver level. We need the following
> 1. For every jdbc statement/prepared statement/ run by PQS , we need
> capability to collect metrics at PQS level and push the data to external sink
> i.e. file, JMX , other external custom sources.
> 2. Besides this global metrics could be periodically collected and pushed to
> the sink.
> 2. PQS can be configured to turn on metrics collection and type of collect (
> runtime or global) via hbase-site.xml
> 3. Sink could be configured via an interface in hbase-site.xml.
> All metrics definition https://phoenix.apache.org/metrics.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
