[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495845#comment-16495845
]
Josh Elser commented on PHOENIX-3655:
-------------------------------------
{quote}Would not this mean that we will have to manage the logic for dumping
metrics to JMX on our own?
{quote}
Nope. We use hbase-metrics-api in our Phoenix code, register the metrics with
create with the MetricsRegistry that HBase already puts up for itself, and then
it will automatically convert the hbase-metrics-api objects to the requisite
hadoop-metrics2 objects which include making them available via JMX.
Down the road, we could push the hbase-metrics-api objects directly to JMX via
our own "Reporter" (which is the dropwizard-metrics name for what the
HbaseMetrics2HadoopMetricsAdapter is essentially doing), but we shouldn't have
to do that now.
> Metrics for PQS
> ---------------
>
> Key: PHOENIX-3655
> URL: https://issues.apache.org/jira/browse/PHOENIX-3655
> Project: Phoenix
> Issue Type: New Feature
> Affects Versions: 4.8.0
> Environment: Linux 3.13.0-107-generic kernel, v4.9.0-HBase-0.98
> Reporter: Rahul Shrivastava
> Assignee: Karan Mehta
> Priority: Major
> Fix For: 4.15.0
>
> Attachments: MetricsforPhoenixQueryServerPQS.pdf
>
> Original Estimate: 240h
> Remaining Estimate: 240h
>
> Phoenix Query Server runs a separate process compared to its thin client.
> Metrics collection is currently done by PhoenixRuntime.java i.e. at Phoenix
> driver level. We need the following
> 1. For every jdbc statement/prepared statement/ run by PQS , we need
> capability to collect metrics at PQS level and push the data to external sink
> i.e. file, JMX , other external custom sources.
> 2. Besides this global metrics could be periodically collected and pushed to
> the sink.
> 2. PQS can be configured to turn on metrics collection and type of collect (
> runtime or global) via hbase-site.xml
> 3. Sink could be configured via an interface in hbase-site.xml.
> All metrics definition https://phoenix.apache.org/metrics.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
