[
https://issues.apache.org/jira/browse/PHOENIX-4741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16483066#comment-16483066
]
Ankit Singhal commented on PHOENIX-4741:
----------------------------------------
{quote}If we're already shading, shouldn't we close this as "Not a Problem"?
{quote}
[~jamestaylor], yes we are shading disruptor library in phoenix-client but not
publishing it to maven. Thus the end user relying on fat jar has no way to
include it in their application pom.
[~elserj] pointed out to me PHOENIX-1567 where we had the similar discussion on
whether to publish such fat jars on maven or not and the conclusion seems to be
that phoenix-core as maven dependency should be enough but at that time we
don't shade our client/servers and there are not many cases of transitive
dependencies which will have conflict with the runtime libraries version, so I
would suggest we should revisit and start publishing our shaded artifacts as
well. Let me know if it's fine, I'll update the
release|http://phoenix.apache.org/release.html] accordingly.
And, there is a bug where during "mvn install" phoenix-client.jar and then
phoenix-server jar are copied in phoenix-core path resulting phoenix-server.jar
to act as our phoenix-core.jar, attached patch should fix it.
> Shade disruptor dependency
> ---------------------------
>
> Key: PHOENIX-4741
> URL: https://issues.apache.org/jira/browse/PHOENIX-4741
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.14.0, 5.0.0
> Reporter: Jungtaek Lim
> Assignee: Ankit Singhal
> Priority: Major
> Fix For: 4.14.0, 5.0.0
>
> Attachments: PHOENIX-4741.patch
>
>
> We should shade disruptor dependency to avoid conflict with the versions used
> by the other framework like storm , hive etc.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
