[
https://issues.apache.org/jira/browse/PHOENIX-3534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495690#comment-16495690
]
ASF GitHub Bot commented on PHOENIX-3534:
-----------------------------------------
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r191925360
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/ExplainPlanWithStatsEnabledIT.java
---
@@ -1202,33 +1202,44 @@ private void
testUseStatsForParallelizationOnSaltedTable(boolean useStatsFlag, b
assertEquals("B", rs.getString(1));
}
- @Test
- public void testUseStatsForParallelizationProperyOnViewIndex() throws
SQLException {
- String tableName = generateUniqueName();
- String viewName = generateUniqueName();
- String tenantViewName = generateUniqueName();
- String viewIndexName = generateUniqueName();
- boolean useStats = !DEFAULT_USE_STATS_FOR_PARALLELIZATION;
- try (Connection conn = DriverManager.getConnection(getUrl())) {
- conn.createStatement()
- .execute("create table " + tableName
- + "(tenantId CHAR(15)
NOT NULL, pk1 integer NOT NULL, v varchar CONSTRAINT PK PRIMARY KEY "
- + "(tenantId, pk1))
MULTI_TENANT=true");
- try (Connection tenantConn =
getTenantConnection("tenant1")) {
- conn.createStatement().execute("CREATE VIEW " +
viewName + " AS SELECT * FROM " + tableName);
- conn.createStatement().execute("CREATE INDEX "
+ viewIndexName + " on " + viewName + " (v) ");
- tenantConn.createStatement().execute("CREATE
VIEW " + tenantViewName + " AS SELECT * FROM " + viewName);
- conn.createStatement()
- .execute("ALTER TABLE " +
tableName + " set USE_STATS_FOR_PARALLELIZATION=" + useStats);
- // fetch the latest view ptable
- PhoenixRuntime.getTableNoCache(tenantConn,
viewName);
- PhoenixConnection phxConn =
conn.unwrap(PhoenixConnection.class);
- PTable viewIndex = phxConn.getTable(new
PTableKey(phxConn.getTenantId(), viewIndexName));
- assertEquals("USE_STATS_FOR_PARALLELIZATION
property set incorrectly", useStats,
- PhoenixConfigurationUtil
-
.getStatsForParallelizationProp(tenantConn.unwrap(PhoenixConnection.class),
viewIndex));
- }
- }
- }
+ @Test
+ public void testUseStatsForParallelizationProperyOnViewIndex() throws
SQLException {
+ String tableName = generateUniqueName();
+ String viewName = generateUniqueName();
+ String tenantViewName = generateUniqueName();
+ String viewIndexName = generateUniqueName();
+ boolean useStats = !DEFAULT_USE_STATS_FOR_PARALLELIZATION;
+ try (Connection conn = DriverManager.getConnection(getUrl())) {
+ conn.createStatement()
+ .execute("create table " + tableName
+ + "(tenantId CHAR(15) NOT NULL, pk1 integer
NOT NULL, v varchar CONSTRAINT PK PRIMARY KEY "
+ + "(tenantId, pk1)) MULTI_TENANT=true");
+ try (Connection tenantConn = getTenantConnection("tenant1")) {
+ conn.createStatement().execute("CREATE VIEW " + viewName +
" AS SELECT * FROM " + tableName);
+ conn.createStatement().execute("CREATE INDEX " +
viewIndexName + " on " + viewName + " (v) ");
+ tenantConn.createStatement().execute("CREATE VIEW " +
tenantViewName + " AS SELECT * FROM " + viewName);
+ conn.createStatement()
+ .execute("ALTER TABLE " + tableName + " set
USE_STATS_FOR_PARALLELIZATION=" + useStats);
+ // changing a property on a base table does not change the
property on a view
--- End diff --
Shouldn't setting a property on the base table impact the view as well? In
this case, USE_STATS_FOR_PARALLELIZATION only makes sense to set on a physical
table. I think we only look it up from a physical table as well, so this is
somewhat moot, but in general, I'd think that setting a property on a base
table should be seen by it's views if the property has not been set there.
> Support multi region SYSTEM.CATALOG table
> -----------------------------------------
>
> Key: PHOENIX-3534
> URL: https://issues.apache.org/jira/browse/PHOENIX-3534
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: Thomas D'Silva
> Priority: Major
> Attachments: PHOENIX-3534-wip.patch
>
>
> Currently Phoenix requires that the SYSTEM.CATALOG table is single region
> based on the server-side row locks being held for operations that impact a
> table and all of it's views. For example, adding/removing a column from a
> base table pushes this change to all views.
> As an alternative to making the SYSTEM.CATALOG transactional (PHOENIX-2431),
> when a new table is created we can do a lazy cleanup of any rows that may be
> left over from a failed DDL call (kudos to [~lhofhansl] for coming up with
> this idea). To implement this efficiently, we'd need to also do PHOENIX-2051
> so that we can efficiently find derived views.
> The implementation would rely on an optimistic concurrency model based on
> checking our sequence numbers for each table/view before/after updating. Each
> table/view row would be individually locked for their change (metadata for a
> view or table cannot span regions due to our split policy), with the sequence
> number being incremented under lock and then returned to the client.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
