chia7712 commented on a change in pull request #74:
URL: https://github.com/apache/phoenix-omid/pull/74#discussion_r522085070
##########
File path: common/src/main/java/org/apache/omid/NetworkUtils.java
##########
@@ -17,15 +17,19 @@
*/
package org.apache.omid;
+import org.slf4j.Logger;
Review comment:
> That would need to be smart, as I don't expect that the current code
base is fully compliant either.
Yetus has this functionality, but we aren't using that for Omid.
sure. that should be addressed by other issue(s). I'm going to open tickets
to include following tasks:
1. add checkstyle:check to validate phase (violations are viewed as warning
rather than error)
1. fix all warnings of common module
1. fix all warnings of ...
1. fail build if there is any violation
@stoty WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
