stoty commented on a change in pull request #74:
URL: https://github.com/apache/phoenix-omid/pull/74#discussion_r522091256
##########
File path: common/src/main/java/org/apache/omid/NetworkUtils.java
##########
@@ -17,15 +17,19 @@
*/
package org.apache.omid;
+import org.slf4j.Logger;
Review comment:
I have recently added Yetus support for phoenix and phoenix-connectors,
you may want to do the same for Omid, so that the Phoenix projects have similar
test setup. Apart from checkstyle, spotbugs is also a highly recommended to
tool for this, for the possible logic errors.
I am not sure what you mean by warnings of common module.
Generally, fixing up the code to address static analysis / checkstyle
warnings is very useful up to a point.
If you have the time and motivation to work on this, then go ahead by all
means!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
