Thank you Istvan for taking a look! I think we should just disable the tests in TransformToolIT, someone needs to dedicate bandwidth to find root cause and fix it. We can’t block release for this the feature which is not quite stable anyways.
Thank you so much for also sharing the script to get hanging tests from output. On Wed, Jul 10, 2024 at 5:02 AM Istvan Toth <st...@apache.org> wrote: > I made a mistake when testing PHOENIX-7353, it doesn't really fix the hang. > > Opened https://issues.apache.org/jira/browse/PHOENIX-7354 to disable the > problematic test on HBase 2.6+. > > Istvan > > On Mon, Jul 8, 2024 at 3:30 PM Istvan Toth <st...@apache.org> wrote: > > > Applying the same fix to TransformToolIT fixes the hang for me locally. > > > > https://issues.apache.org/jira/browse/PHOENIX-7353 > > > > On Mon, Jul 8, 2024 at 2:25 PM Istvan Toth <st...@cloudera.com> wrote: > > > >> Copying here my trivial script for finding the hanging test: > >> This can be used on the maven output downloaded from jenkins: > >> > >> cat hang.log | grep "Running org.apache" |sed -n -e > 's/^.*\(org.apache.*$\)/\1/p' |sort > started > >> cat hang.log | grep "in org.apache" |sed -n -e > 's/^.*\(org.apache.*$\)/\1/p' |sort > finished > >> diff started finished > >> > >> > >> org.apache.phoenix.end2end.transform.TransformToolIT is the hanging > test. > >> > >> Istvan > >> > >> On Thu, Jul 4, 2024 at 10:55 PM Viraj Jasani <vjas...@apache.org> > wrote: > >> > >>> Thanks Geoffrey! > >>> > >>> Btw I just realized that we still have broken/aborted builds for HBase > >>> 2.6 > >>> profile, some tests are hanging and not making any progress. I resolved > >>> some of them in recent commit but looks like we still have more of > them. > >>> > >>> This would need running build with HBase 2.6 profile locally (since we > >>> don’t have 2.6 output on multibranch builds). If anyone had more > >>> bandwidth > >>> or insights into this, please let me know, we can work on resolving > test > >>> issues. I will be back next week. > >>> > >>> This is blocker for 5.2.1 release. > >>> > >>> > >>> On Wed, Jul 3, 2024 at 9:47 AM Geoffrey Jacoby <gjac...@apache.org> > >>> wrote: > >>> > >>> > +1. There's a good set of fixes plus a few nice new features here > [1]. > >>> In > >>> > general more regular releases are good for the community, so it's > good > >>> > seeing us get on a more frequent cadence. > >>> > > >>> > Geoffrey > >>> > > >>> > [1] > >>> > > >>> > > >>> > https://issues.apache.org/jira/issues/?jql=project%20%3D%20PHOENIX%20AND%20status%20in%20(Resolved%2C%20Closed)%20AND%20fixVersion%20%3D%205.2.1 > >>> > > >>> > On Wed, Jul 3, 2024 at 12:44 AM Viraj Jasani <vjas...@apache.org> > >>> wrote: > >>> > > >>> > > Hi, > >>> > > > >>> > > We have sufficient changes, improvements and fixes available on the > >>> 5.2 > >>> > > branch to start 5.2.1 release. A couple of improvements can still > be > >>> > > included with the 5.2.1 release (e.g. bloom filter for multi-point > >>> > > lookups). > >>> > > > >>> > > I can start off with the release process by the end of next week > >>> unless > >>> > > there are any objections. Please let me know if you think any other > >>> > > important fixes or improvements are worth including in the release. > >>> > > > >>> > > >>> > >> > >> > >> -- > >> *István Tóth* | Sr. Staff Software Engineer > >> *Email*: st...@cloudera.com > >> cloudera.com <https://www.cloudera.com> > >> [image: Cloudera] <https://www.cloudera.com/> > >> [image: Cloudera on Twitter] <https://twitter.com/cloudera> [image: > >> Cloudera on Facebook] <https://www.facebook.com/cloudera> [image: > >> Cloudera on LinkedIn] <https://www.linkedin.com/company/cloudera> > >> ------------------------------ > >> ------------------------------ > >> > > >
