Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r9982858
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/PArrayDataType.java ---
@@ -146,11 +237,16 @@ public static void
positionAtArrayElement(ImmutableBytesWritable ptr, int arrayI
}
if (baseDataType.getByteSize() == null) {
- int offset = ptr.getOffset() + noOFElementsSize +
Bytes.SIZEOF_BYTE;
- int indexOffset = Bytes.toInt(bytes, offset) +
ptr.getOffset();
- int valArrayPostion = offset + Bytes.SIZEOF_INT;
- offset += Bytes.SIZEOF_INT;
+ int offset = ptr.getOffset();
--- End diff --
Yes, the current offset for the next element should not point to the zero
byte - if that's the case, you'll definitely want to fix it. If the byte at an
offset if a zero byte, no need to do anything else, as this is definitely a
null.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
[email protected] or file a JIRA ticket with INFRA.
---
